Using isset or is not set PHP variable with extra fields?

Question

I have an issue with setting up variables - if the custom field is filled then it should be shown, if it's empty - then date (+1 month from today's date) is shown.

However, it doesn't work properly. Custom field values are shown as they should, but I can't get the date if the field value is empty.

<?php

if (isset($fields['exp-date'])) {
    echo $field_value = $fields['exp-date']->rawvalue;
    $timeset = $fields['exp-date']; // then assign
}
if (!isset($fields['exp-date'])) {
    echo (new DateTime('+1 month'))->format('d.m.Y');
    $timeset = '';
}
?>

P.S. I get custom fields shown in module using the next code and FieldsHelper (everything works perfectly).

<?php
$item->jcfields = FieldsHelper::getFields('com_content.article', $item, true);
$fields = [];
foreach($item->jcfields as $jcfield)
{
    $fields[$jcfield->name] = $jcfield;
}
?>

Answer 1

There is a difference between !isset and empty in PHP so while your code is looking at isset vs !isset but your description is saying empty or not empty.

Your field 'exp-date' can exist but have no value in it meaning it is empty.

Your second statement could be changed to check if the field isset and empty

if (isset($fields['exp-date']) && empty($fields['exp-date'])) {
    echo (new DateTime('+1 month'))->format('d.m.Y');
    $timeset = '';
}

You might find this explanation useful , particularly the table that shows the different states, https://www.virendrachandak.com/techtalk/php-isset-vs-empty-vs-is_null/

Answer 2

Thanks @Irata, your code didn't work for me, but the clues and the provided link gave me a hint.

This is my new code which works as required (although I'm not sure why it works and how I got it):

$field_value = $fields['exp-date']->rawvalue;
$timeset = $field_value;

if (!empty($timeset))
{
    echo $field_value = $fields['exp-date']->rawvalue;
}
else
{
    echo (new DateTime('+1 month'))->format('d.m.Y');
}