Where to use JInput in MVC

Question

I'm curious as to where to get data from JInput in the MVC design pattern. For example, in a situation where I need a JInput value to use in a query in a model class method, should I get the JInput value there or should I pass it from the view or does it matter?

Answer 1

In a proper MVC structure, only your controller should interface with your request data, in this case JInput, and the dependencies injected into the view and model when instantiated within the controller.

With the current CMS structure, all three pieces of the MVC structure are often interfacing with the request data. In models, this is usually done in the populateState() method and views are more often in the layout files they are loading up than the actual class.

Answer 2

I'm of the strong belief that it should be retrieved where appropriate.

That is to say you should always use JInput otherwise you're duplicating data and potentially breaking DRY principles.

A view class should be retrieving data to populate the the view's templates (/tmpl files) or layouts from the model, not injecting values into the model. A view after all is about presentation of data and UI not manipulation of data or handling of user actions.

Answer 3

JInput doesn't offer such feature; so you might have to use $_POST.

if you can have the input be in the form of array (and use JInput::getArray() )

or

a json-encoded object (you use json_decode(JInput::getString()))

http://developer.joomla.org/manual/chap-Joomla_Platform_Manual-Input.html

http://docs.joomla.org/Retrieving_request_data_using_JInput

Answer 4

Though already answered, I'll try to explain in my on perspective.

Joomla! is a really great and flexible MVC Implementation.

About your problem of populating a View, with data from Model, depending on the user submitted data through $_GET. Here is how I do it.

First thing I'd like to state is that Besides the common Models, Views and Controllers there is another category of files used widely in Joomla!, those are the mini-Controllers. Yup you read it correct.

These are the files directly inside the view folder.

Here are a few of them.

view.html.php
view.raw.php
view.pdf.php

Apart from serving the purpose of generating different types of output, they also serve as a controller(In a way).

So for case like yours, one doesn't have to involve controllers just to get the data from the model. All you have to do is get the submitted data using jinput sanitize it and the pass the data as an object or array or just plain variable, to the Model.

Heres an example:

view.html.php
<?php
//-- No direct access
defined('_JEXEC') || die('=;)');

class compoViewDashboard extends JViewLegacy {
    public function display($tpl = null) {
        if (JRequest::getVar('layout') == 'somelayout') {
            $jinput = JFactory::getApplication()->input;
            $data = $jinput->post->get('xyz', 'null', 'INT');

            /* If you are calling method from other(different) model you can use the following one line else you can skip it. */
            $this->setModel(JModelLegacy::getInstance('syllabus', 'compoModel'));
            $model = $this->getModel('syllabus');
            $this->courses= $model->getcourses($data);
        }
        parent::display($tpl);
    }
}

Thats it.

Disclaimer:- Remember that this is my own implementation, and may not be that perfect way, so get this approved by the pros before using any of my code in production environment.

Note:- I know JRequest is deprecated, but its there to stay as per the Joomla! core team, since the core too uses it all over the place.

Answer 5

I will usually use JInput in the controller to route the request, then pass the request to the model via a registry object.

Ideally you'd be passing the request data to the controller from your router logic, in order to make DI easy in your controllers but...at least this way the request dependencies are injected into the model and I don't need access to JInput to test it.

Once I have the data in the model, I can use it to set the model state, then the controller injects that model into the view with all the data necessary to fulfill the view data reqs already loaded into its properties.