Model not found when from a controller

Question

In a controller, I am trying to load the model, but I have the following error:

Call to a member function getSearchURL() on bool

So the getModel() is returning false. This is the code of my controller, MycomponentController just extend BaseController:

namespace Example\Mycomponent\Site\Controllers;

class SearchController extends MycomponentController
{
    public function __construct($config = [])
    {
        parent::__construct($config);
    } 
   
    public function results()
    {
        $model = $this->getModel('Search');
        $this->setRedirect(
            $model->getSearchURL(
                'search',
                $model->getState('searchwords'),
                $model->getState('list.start'),
                $model->getState('list.limit'),
                $model->getUrlParams(),
                false
            )
        );
    }
}

The class MycomponentController is the following :

namespace Example\Mycomponent\Libraries\Controller;

use Joomla\CMS\MVC\Controller\BaseController;
use Joomla\CMS\MVC\Factory\MVCFactoryInterface;

class MycomponentController extends BaseController
{
    public function __construct($config = [], MVCFactoryInterface $factory = null, $app = null, $input = null)
    {
        $this->app      = Factory::getApplication();
    
        if (empty($this->input))
        {
            $this->input = $this->app->input;
        }

        parent::__construct($config, $factory, $app, $input);
    }
}

The model is named SearchModel.php and is the following:

namespace Example\Mycomponent\Site\Model;

class SearchModel extends MycomponentModel
{
    public function getSearchURL($view, $searchword = '', $limitstart = 0, $limit = 0, $params = '', $xhtml = true)
    {
    }
}

So why is the controller unable to find the model?

P.S.: I have found that it goes to Joomla\CMS\MVC\Factory\LegacyFactory::createModel() then her it call Joomla\CMS\MVC\Model\LegacyModelLoaderTrait::getInstance() but here it doesn't loads by namespace but by old way, because the Joomla\CMS\MVC\Model\LegacyModelLoaderTrait::getInstance() clean all the namepsapce by removing the \

Answer 1

MycomponentController class is missing the class prefix. It should be -

namespace Example\Mycomponent\Libraries\Controller;

use Joomla\CMS\MVC\Controller\BaseController;
use Joomla\CMS\MVC\Factory\MVCFactoryInterface;

class MycomponentController extends BaseController
{
    public function __construct($config = [], MVCFactoryInterface $factory = null, $app = null, $input = null)
    {
        $this->app      = Factory::getApplication();
    
        if (empty($this->input))
        {
            $this->input = $this->app->input;
        }

        parent::__construct($config, $factory, $app, $input);
    }
}

If it does not help, try by declaring the getModel method in the search controller class -

namespace Example\Mycomponent\Site\Controllers;

class SearchController extends MycomponentController
{
    public function __construct($config = [])
    {
        parent::__construct($config);
    } 
   
    public function results()
    {
        $model = $this->getModel('Search');
        $this->setRedirect(
            $model->getSearchURL(
                'search',
                $model->getState('searchwords'),
                $model->getState('list.start'),
                $model->getState('list.limit'),
                $model->getUrlParams(),
                false
            )
        );
    }
    
    public function getModel($name = 'Search', $prefix = 'Site', $config = array('ignore_request' => true))
    {
        return parent::getModel($name, $prefix, $config);
    }
}

Answer 2

As far I am aware, feel free to correct me as I haven't played with Joomla 4 too much, the class naming conventions for controllers, models and views you need to use for Joomla to automatically resolve and load the related classes are the same as Joomla 3 and PSR/4 therefore your Controller and Model class name should be changed to class MycomponentControllerSearch & MycomponentModelSearch As per Zollie's comment the above does not apply to Joomla4

If you want to keep the names you have you need to tell Joomla where to find the Model, therefore you need to add your Models path to the list of paths to search. In Joomla 4 there is this method in the /libraries/src/MVC/Controller/BaseController.php that I think you are supposed to use

/**
 * Adds to the stack of model paths in LIFO order.
 *
 * @param   mixed   $path    The directory (string), or list of directories (array) to add.
 * @param   string  $prefix  A prefix for models
 *
 * @return  void
 *
 * @since   3.0
 */
public static function addModelPath($path, $prefix = '')
{
    BaseModel::addIncludePath($path, $prefix);
}

In your Controller you can use $this->addModelPath(JPATH_SITE . '/components/com_mycomponent/models' which seems to be the correct way from what I could see.

You could add a USE statement and call BaseModel::addIncludePath($path) directly like a lot of examples I found but it is depreciate in Joomla 5.0

Answer 3

I am also only taking my first steps in Joomla 4. Like Irata I think, that it is best to use the Joomla Standard.

Another possibility might be that your controller class extends

Joomla\CMS\MVC\Controller\AdminController;

or

Joomla\CMS\MVC\Controller\BaseController;

and overwrites the method getModel() so that the model is found.