Get form input in custom field

Question

I'm currently working on a custom field, where I manually add a checkbox to a file upload field. PDF Upload field

In onContentBeforeSave I want to read this checkbox to decide what to do with the file upload. I figured out to get the checkbox with

$jinput->post->getArray()['jform']['com_fields'][$fieldname.'_choverride']

It works, but I thought it's a pretty ugly call.

Is there a nicer, better way to do this?

Edit: Other solutions

Solution 2

$choveride_res = $postData->getArray(array(
            'jform' => array(
                'com_fields' => array(
                    $fieldData["fieldName"] . '_choverride' => 'string'
                )
            )
        ));
$res = $choveride_res['jform']['com_fields'][$fieldData["fieldName"] . '_choverride'];

Solution 3

$postData  = JFactory::getApplication()->input->post;
$jform     = new JRegistry($postData->get('jform', null, 'array'));
$comFields = new JRegistry($jform->get('com_fields', null, 'array'));
$choveride = $comFields->get($fieldData["fieldName"] . '_choverride', '', 'string');

Answer 1

I agree that your "Solution 2" is better because it implements a more readable syntax.

I might be a little too nitpicky because I have been spending time volunteering at CodeReview, but perhaps you could clarify your variable naming. Your abbreviated naming is probably very clear to you, but it will make your code more readable for other developers if you avoid shortening your variable names. $choveride_res = "checkbox override result" and $res = "result" Mind you, I have seen far worse/ambiguous variable naming, I just think there is some benefit to be had from using a few more characters.

Maybe something like:

$filteredPostData = $postData->getArray(array(
            'jform' => array(
                'com_fields' => array(
                    $fieldData["fieldName"] . '_choverride' => 'string'
                )
            )
        ));
$checkboxValue = $filteredPostData['jform']['com_fields'][$fieldData["fieldName"] . '_choverride'];

Ultimately, you've found your solution, I just wanted to give you confirmation and some food for thought.