Joomla.submitbutton (...) stops working after 3.4.2 update

Question

I just updated my local Xampp and a view remote sites from 3.4.1 to 3.4.2 and all (as far as I have tested) my custom components stopped being able to save, cancel form dialogs in the back end.

What I mean is the action buttons in the List views work. 'Add new item', 'Edit item' .. will load the forms, but then neither save, cancel will do anything!

• The client validation is triggered, but nothing is forwarded after that.
• NO php error
• No Joomla error
• No JS error ..

3.4.2 update only talks about minor security fixes!. ANY ideas?

I'm happy to post code, but at this point I have no idea which parts.

    JToolBarHelper::save('simplelist.save');
    JToolBarHelper::cancel('simplelist.cancel');

I checked with the Banner component, it doesn't look different from what I do, yet they are all still working

Answer 1

It turns out my problem was caused by the use of the onsubmit="" event at the form tag. NOTE: This is back-end code, I only have this problem when using the JToolBarHelper::buttons();

Here is what I used to do:

view.html.php

JToolBarHelper::save('simplelistitem.save');
JToolBarHelper::apply('simplelistitem.apply')

edit.php

<script>
    function extraValidationAAA(){ 
        if(jQuery('aa').val() === 'aaa'){ return true;} else {return false;}
    }
</script>

<form action=".." onsubmit="extraValidationAAA();" id='exampleForm' >
..
</>

This fails to submit my forms starting 3.4.2, even if valid. Taking a look at the com_banner / edit.php I tried using Joomla.submitbutton = function(){...}.

New edit.php

<script>
    var thisForm = document.getElementById("exampleForm");
    Joomla.submitbutton = function(task)    {
        if (task == "simplelistitem.cancel"){
           Joomla.submitform(task, thisForm );
        }
        else if (document.formvalidator.isValid(thisForm))
        {
            //add any additional validation here
            if(jQuery('aa').val() === 'aaa'){
                Joomla.submitform(task, thisForm );
            }
        }
    };
</script>

<form action=".."  id='exampleForm' >
..
</>

I lage the knowledge to explain why, nor do I know what changed in 3.4.2 to break my approach.

Answer 2

Joomla 3.4.2 has some known issues.

I'm not sure if it's related to yours, however they will be releasing Joomla 3.4.3 tomorrow, so I'd wait and install that update first.

Answer 3

Having the same issue, seems 3.4.x has changed the way you call the validation. https://docs.joomla.org/Client-side_form_validation

I changed JHTML::_('behavior.formvalidation'); to JHTML::_('behavior.formvalidator'); and replaced onsubmit="return doValidate( this );" with class="form-validate". Works as expected now, and the form no longer highlights the invalid form fields when you cancel/back out of the form (the form would still validate fields even when you were canceling the form edit using the old method).